Skip to content

[SPARK-6196][build]Add MAPR 4.0.2 support to the build#7047

Closed
trystanleftwich wants to merge 1 commit into
apache:masterfrom
trystanleftwich:SPARK-6196
Closed

[SPARK-6196][build]Add MAPR 4.0.2 support to the build#7047
trystanleftwich wants to merge 1 commit into
apache:masterfrom
trystanleftwich:SPARK-6196

Conversation

@trystanleftwich

Copy link
Copy Markdown

No description provided.

@AmplabJenkins

Copy link
Copy Markdown

Can one of the admins verify this patch?

@JoshRosen

Copy link
Copy Markdown
Contributor

@pwendell or @srowen do either of you have an opinion on this patch?

@srowen

srowen commented Aug 3, 2015

Copy link
Copy Markdown
Member

So, I have this standing mild objection to the vendor-specific builds in general mostly on the grounds they don't quite work (e.g. CDH4) and are de facto not supported by the upstream Spark project, and certainly not supported by vendors. I don't think this accomplishes therefore the apparent goal of making sure Spark can get to users' hands no matter what vendors do. But maybe not the place to rehash that now.

This is better in that it pulls the logic out of the pom. Are two maintenance releases different enough to need different builds entirely @trystanleftwich ? As it's at least a little improvement over the current state, seems OK to me.

@pwendell

pwendell commented Aug 4, 2015

Copy link
Copy Markdown
Contributor

@trystanleftwich we are actually recommending that MapR users use the "hadoop provided" builds that became available in Spark 1.4. You just add the MapR hadoop bindings to the class at runtime. Is there any reason you can't do that? I think MapR's own Spark distribution is using those as well.

@srowen

srowen commented Aug 7, 2015

Copy link
Copy Markdown
Member

@pwendell are you suggesting we remove the mapr builds here (and add in hadoop-provided docs)? I'd also support that... what about HDP though? I'd be surprised if the same didn't apply.

I'm OK with this change as an incremental improvement on the current state, but still wonder whether two different maintenance releases need mention? doc 4.0.2?

@srowen

srowen commented Aug 11, 2015

Copy link
Copy Markdown
Member

@trystanleftwich are you able to follow up on @pwendell's question? Also note this is removing the mapr 3 build and I have no idea what effect that has. I remain OK with this change if it doesn't have two mapr 4.0.x profiles -- seems superfluous -- or else needs an explanation why both should be special-cased by Spark.

@srowen

srowen commented Aug 17, 2015

Copy link
Copy Markdown
Member

Do you mind closing this PR? I will propose an alternative

asfgit pushed a commit that referenced this pull request Aug 25, 2015
Follow up to #7047

pwendell mentioned that MapR should use `hadoop-provided` now, and indeed the new build script does not produce `mapr3`/`mapr4` artifacts anymore. Hence the action seems to be to remove the profiles, which are now not used.

CC trystanleftwich

Author: Sean Owen <sowen@cloudera.com>

Closes #8338 from srowen/SPARK-6196.

(cherry picked from commit 57b960b)
Signed-off-by: Sean Owen <sowen@cloudera.com>
asfgit pushed a commit that referenced this pull request Aug 25, 2015
Follow up to #7047

pwendell mentioned that MapR should use `hadoop-provided` now, and indeed the new build script does not produce `mapr3`/`mapr4` artifacts anymore. Hence the action seems to be to remove the profiles, which are now not used.

CC trystanleftwich

Author: Sean Owen <sowen@cloudera.com>

Closes #8338 from srowen/SPARK-6196.
@JoshRosen

Copy link
Copy Markdown
Contributor

I think it's safe to close this PR at this point; we can always re-open later if we choose to revive this discussion.

@asfgit asfgit closed this in 8d4449c Oct 18, 2015
kiszk pushed a commit to kiszk/spark-gpu that referenced this pull request Dec 26, 2015
Follow up to apache/spark#7047

pwendell mentioned that MapR should use `hadoop-provided` now, and indeed the new build script does not produce `mapr3`/`mapr4` artifacts anymore. Hence the action seems to be to remove the profiles, which are now not used.

CC trystanleftwich

Author: Sean Owen <sowen@cloudera.com>

Closes #8338 from srowen/SPARK-6196.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants